Optimize ASCII lowercase conversion performance - #15203
Merged
Merged
Conversation
Miladkhoshdel
force-pushed
the
perf/optimize-lower
branch
from
September 6, 2026 11:13
3de987a to
74bc163
Compare
cclauss
requested changes
Sep 6, 2026
cclauss
left a comment
Member
There was a problem hiding this comment.
Please add a benchmark that proves that the proposed changes provide significant runtime improvements.
mindaugl
approved these changes
Sep 6, 2026
Contributor
Author
Thanks for the feedback. I benchmarked both implementations under the same conditions using timeit.repeat(). Benchmark codeResults: Both implementations were tested with the same inputs, iteration counts, and number of repeats. Across the tested input sizes, the proposed implementation shows a consistent median runtime improvement of approximately 27–29%. |
cclauss
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Improve the performance of the existing ASCII lowercase conversion by replacing the generator expression with an explicit loop.
The updated implementation:
Benchmark using:
Results on my machine:
Checklist: